Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loading=lazy attribute on images excluded from lazyload #121

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

remyperona
Copy link
Contributor

Description

Documentation

User documentation

Remove loading=lazy attribute on images excluded from lazyload

Technical documentation

Use preg_replace() to remove the attribute if it exists.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Documentation

  • I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
  • The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
  • I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

  • I wrote self-explanatory code about what it does.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.

@remyperona remyperona added the enhancement New feature or request label Aug 2, 2024
@remyperona remyperona requested a review from a team August 2, 2024 19:36
@remyperona remyperona self-assigned this Aug 2, 2024
@remyperona remyperona merged commit 5423fb2 into trunk Aug 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants